Ticket #70 (closed task: fixed)

Opened 2 years ago

Last modified 22 months ago

Tagging system - Tagbrowser

Reported by: tklein Owned by: tklein
Priority: blocker Milestone: 0.2
Component: Tagging System Keywords:
Cc: wblanton, rh36gd

Description (last modified by tklein) (diff)

With the "Tags View" in the Bible Browser it's not possible to see all the verses assigned to a tag, because you can only see one book at a time.

There should be a way of accessing all verses assigned to a certain tag, so we need a "Tag Browser".

The new "Tag Browser" would be on the same level as the current "Bible Browser". So we need a new tab bar with a "MAIN MENU" for this (probably directly under the title bar).

The "Online Help" will also be moved into that new "MAIN MENU". So it would like like in the following illustration:

[*Bible Browser*] [Tag Browser] [Online Help]   <---- MAIN MENU
---------------------------------------------
[Outline] [*Tags*] [Notes]                      <---- SUB MENU

For the new Tag Browser, which would show up after clicking the entry in the MAIN MENU, the interface would like like this:

Tags              |   Verses tagged with "Memory verses"
****              |   **********************************
                  |   
                  |   [-] Collapse all
                  |
[ ] God's grace   |   [-] John 3:16
[X] Memory verses |   ........
[ ] Illustrations |   ........
[ ] OT quotes     |
                  |   [-] John 14:6
                  |   ........
                  |   ........
                  |
                  |   [-] Romans 5:8
                  |   ..........   
                  |   ..........

The verse references on the right side would also be links to the Bible Browser. Clicking on a tag would result in the Bible Browser showing up with the context of the selected verse reference.

Furthermore the verses on the right side are collapsible with one global button. So there would be a way of showing only the verse references.

Any objections?

Change History

  Changed 2 years ago by tklein

  • status changed from new to accepted

follow-up: ↓ 4   Changed 2 years ago by wblanton

Looks good. Would the reference be hyperlinked as well, or just written out below it? It would be nice to have a collapsible feature, so that if there is a lot of text, you can get it "out of the way" in order to view just the references.

  Changed 2 years ago by wblanton

[*Bible browser*] [Tag browser] [Online help]


[Outline] [Tags] [Notes]

Also, in the above, this is the main menu? Is this showing [Outline], [Tags], and [Notes] a subsection of Bible Browser?

in reply to: ↑ 2   Changed 2 years ago by tklein

Replying to wblanton:

Looks good. Would the reference be hyperlinked as well, or just written out below it? It would be nice to have a collapsible feature, so that if there is a lot of text, you can get it "out of the way" in order to view just the references.

I guess it would be good to have a link to the bible browser, right? So after clicking on a verse reference within the tag browser you would see the bible browser showing the verse in its context. Is that would you mean?

Replying to wblanton:

Also, in the above, this is the main menu? Is this showing [Outline], [Tags], and [Notes] a subsection of Bible Browser?

The main menu contains Bible Browser / Tag Browser / Help. The submenu of Bible Browser would contain Outline / Tags / Notes. Does that make sense?

  Changed 2 years ago by tklein

  • description modified (diff)

Added the collapsible and link feature to the ticket description...

  Changed 2 years ago by tklein

  • cc rh36gd added

  Changed 2 years ago by tklein

  • description modified (diff)

Changed the ticket description. The ASCII illustration for the new main menu is now less ambiguous.

  Changed 2 years ago by wblanton

very nice!

  Changed 2 years ago by wblanton

What would be under the tag browser section?

  Changed 2 years ago by tklein

  • description modified (diff)

Changed the description, so that the difference between the existing "Tags view" and the new "Tags Browser" is more clear.

  Changed 23 months ago by tklein

(In [108])

see #7,#50,#68,#69,#70

Layout changed to include new main menubar

  • BibleBook?.tag_statistics added
  • Term "persistance" renamed to "communication"
  • Open print version renamed to "Printable Version"
  • #toolbox renamed to #bible-browser-toolbox
  • Delete button gets disabled when deletion not possible
  • Enable / disable the "show tag verses button" depending on availability of tag assignments

follow-up: ↓ 14   Changed 23 months ago by wblanton

Out of curiosity, is there a reason you have a shaded box appear over text as you are selecting which verses to tag?

follow-up: ↓ 15   Changed 23 months ago by wblanton

Also, instead of having a section above the "new tag" button that shows all the verses associated with that tag, what about having those appear under the tagged word in the browser.

[*Bible Browser*] [Tag Browser] [Online Help]


[Outline] [*Tags*] [Notes]


[New Tag] Search:


[x][+][->] God's grace
[x][-][->] Memory verses

5:12; 5:23-25

[x][+][->] Illustrations
[x][+][->] OT quotes

Also, when one hovers over the box that they can select or deselect a check mark, it should inform them it will deselect all verses or untag them and vice versa.

in reply to: ↑ 12   Changed 23 months ago by tklein

Replying to wblanton:

Out of curiosity, is there a reason you have a shaded box appear over text as you are selecting which verses to tag?

Well... no. It's part of the default styling which comes from the library that I'm using for the select functionality. I haven't figured out yet, how to change it. It would be better to have it transparent, right?

in reply to: ↑ 13   Changed 23 months ago by tklein

Replying to wblanton:

Also, instead of having a section above the "new tag" button that shows all the verses associated with that tag, what about having those appear under the tagged word in the browser.

[*Bible Browser*] [Tag Browser] [Online Help]
---------------------------------------------
[Outline] [*Tags*] [Notes]
---------------------------------------------
[New Tag] Search:
---------------------------------------------
[x][+][->] God's grace
[x][-][->] Memory verses
5:12; 5:23-25
[x][+][->] Illustrations
[x][+][->] OT quotes


Also, when one hovers over the box that they can select or deselect a check mark, it should inform them it will deselect all verses or untag them and vice versa.

Good ideas... I will think about it!

  Changed 22 months ago by tklein

(In [111]) Refactoring of User Interface... this changeset was a lot of work :-)

User visible changes:

  • New editable attribute for outlines: Author (closes #75)
  • The contents of a bible book are now loaded with an ajax request
  • Universal tags and book tags are now displayed within a "accordion" menu
  • Revamped book selection menu (first version, closes #51)
  • First version of Tag Browser implemented (see #70)
  • Outline sections can now be deleted from the Outline Tab (closes #40)
  • The outline can now be hidden by clicking on a checkbox (closes #76)
  • Show a confirmation dialog before a tag would be deleted
  • The list of tags within the Bible Browser can now be searched / filtered

Internal changes:

  • New "main" controller which handles the basic layout
  • bible book identifier is now the short title rather than the db id
  • Moved code from "main_menu" into bible browser (book selection menu, chapter selection and outline options)
  • Cleaned up OutlineCommunicationController?
  • Prefix "process_" renamed into "handle_" (concerns function names)
  • Various refactoring changes

  Changed 22 months ago by tklein

  • status changed from accepted to closed
  • resolution set to fixed

First version ready for production use. There are several things still to be done. But as we want to have a on time release, the missing work is postponed to the next release. We should create a more detailed concept for the display of the verse list within the tag browser. Ideas will automatically arise by working with the new "simple" version of the tag browser :-)

Note: See TracTickets for help on using tickets.